https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5040
Cal Turney <turney_cal@xxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4945|0 |1
is obsolete| |
Attachment #4998| |review_for_checkin?
Flag| |
--- Comment #17 from Cal Turney <turney_cal@xxxxxxx> 2010-08-04 13:06:19 PDT ---
Created an attachment (id=4998)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4998)
Updated patch to display WS version in main screen's title bar
Here is the call tree tree concerning the main window title with my changes:
set_display_filename(*cf)
[If the capture filename is set, pass it to set_man_window_name, else
set the title to "The Wireshark Network Analyzer" and return]
* Calls set_main_window_name(window_name)
set_main_window_name(window_name);
[Sets main_window_name = filename or some other title but displays
nothing]
* Calls update_main_window_title()
update_main_window_title()
[Constructs the title as follows:
“<window_name> <[user_title]> <[wireshark_version]>”
and displays the title in the main window’s title bar and icon]
Calls: create_user_window_title() (see below)
gtk_window_set_title()
gdk_window_set_icon_name()
create_user_window_title(*caption)
[If prefs.gui_window_title is set, return “<caption> <user_title>”
otherwise “<caption>”]
The three components of the main screen title are now assembled and displayed
in update_main_window_title() which simplifies the code, prevents
inconsistencies, and improves maintainability. Storing of the capture filename
in 'recent' has been moved out of set_display_filename() to
main_cf_cb_file_read_finished() because it seems to make more sense there.
Whenever a capture is not displayed or a new capture hasn't been named yet, the
window_name is set to "The Wireshark Network Analyzer" but I'd just as soon set
it to "".
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.