Wireshark-bugs: [Wireshark-bugs] [Bug 5071] NetrLogonControl2 - Control_data_information "name"

Date: Mon, 2 Aug 2010 08:48:44 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5071

Frank Schorr <fschorr@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4991|                            |review_for_checkin?
               Flag|                            |

--- Comment #1 from Frank Schorr <fschorr@xxxxxxxxxxx> 2010-08-02 08:48:42 PDT ---
Created an attachment (id=4991)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4991)
Proposed patch to add data information to packet-dcerpc-netlogon.c

Proposed patch to add data information to packet-dcerpc-netlogon.c for
NetLogonControl2():

Index: packet-dcerpc-netlogon.c
===================================================================
--- packet-dcerpc-netlogon.c    (revision 33692)
+++ packet-dcerpc-netlogon.c    (working copy)
@@ -103,7 +103,10 @@

 static GHashTable *netlogon_auths=NULL;
 static GHashTable *schannel_auths;
-
+/* Added next two lines for decoding NetrLogonControl2 
+   Control_data_information Level. Frank Schorr */
+static gint hf_netlogon_TrustedDomainName_string = -1; 
+static gint hf_netlogon_UserName_string = -1;          
 static gint DomainInfo_sid = -1;
 static gint DnsDomainInfo_sid = -1;
 static gint DnsDomainInfo_domain_guid = -1;
@@ -4901,13 +4904,15 @@
     ALIGN_TO_4_BYTES;
     switch(level){
     case 5:
-        offset = dissect_ndr_str_pointer_item(tvb, offset, pinfo,
-                                              tree, drep, NDR_POINTER_UNIQUE,
"unknown",
+        offset = dissect_ndr_str_pointer_item(tvb, offset, pinfo,            
+        /* Changed for decoding NetrLogonControl2 Control_data_information
Level. Frank Schorr */
+                                tree, drep, NDR_POINTER_UNIQUE, "Trusted
Domain Name",
                                               hf_netlogon_unknown_string, 0);
         break;
     case 6:
         offset = dissect_ndr_str_pointer_item(tvb, offset, pinfo,
-                                              tree, drep, NDR_POINTER_UNIQUE,
"unknown",
+        /* Changed for decoding NetrLogonControl2 Control_data_information
Level. Frank Schorr */ 
+                                        tree, drep, NDR_POINTER_UNIQUE,
"Trusted Domain Name",
                                               hf_netlogon_unknown_string, 0);
         break;
     case 0xfffe:
@@ -4916,7 +4921,8 @@
         break;
     case 8:
         offset = dissect_ndr_str_pointer_item(tvb, offset, pinfo,
-                                              tree, drep, NDR_POINTER_UNIQUE,
"unknown",
+        /* Changed for decoding NetrLogonControl2 Control_data_information
Level. Frank Schorr */
+                                        tree, drep, NDR_POINTER_UNIQUE,
"UserName",
                                               hf_netlogon_unknown_string, 0);
         break;
     }
@@ -8227,6 +8233,14 @@
         { &hf_netlogon_unknown_string,
           { "Unknown string", "netlogon.unknown_string", FT_STRING, BASE_NONE,
             NULL, 0, "Unknown string. If you know what this is, contact
wireshark developers.", HFILL }},
+    /* Added for decoding NetrLogonControl2 Control_data_information Level.
Frank Schorr */
+    { &hf_netlogon_TrustedDomainName_string,
+        { "TrustedDomainName", "netlogon.TrustedDomainName", FT_STRING,
BASE_NONE,
+        NULL, 0, "TrustedDomainName string.", HFILL }},
+    /* Added for decoding NetrLogonControl2 Control_data_information Level.
Frank Schorr */
+    { &hf_netlogon_UserName_string,
+        { "UserName", "netlogon.UserName", FT_STRING, BASE_NONE,
+        NULL, 0, "UserName string.", HFILL }},

         { &hf_netlogon_dummy_string,
           { "Dummy String", "netlogon.dummy_string", FT_STRING, BASE_NONE,

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.