Wireshark-bugs: [Wireshark-bugs] [Bug 2384] SMPP+ which is customized by Huawei company can't be

Date: Fri, 2 Jul 2010 03:46:46 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2384

Abhik Sarkar <sarkar.abhik@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1596|0                           |1
        is obsolete|                            |
   Attachment #4871|                            |review_for_checkin?
               Flag|                            |

--- Comment #23 from Abhik Sarkar <sarkar.abhik@xxxxxxxxx> 2010-07-02 03:46:39 PDT ---
Created an attachment (id=4871)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4871)
Revised patch

I have massaged the patch to apply against the latest version of packet-smpp.c.

Checks done on the patch:
- checkhfs
- checkAPIs
- Fuzz tests
 * 100 passes with the capture which Xu Bo attached to this bug.
 * 7 passes with a capture with around 40000 (normal) SMPP PDUs & about the
same number of HTTP requests.

NOTE: I have changed some of the HF names and descriptions to make it clear
that these are proprietary extensions & also made the spelling/grammatical
corrections. Hopefully Xu Bo doesn't mind my making these changes.

I will try once again to find some time to figure out a configurable way of
supporting proprietary commands/TLVs...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.