Wireshark-bugs: [Wireshark-bugs] [Bug 4887] Adding support for Gigamon headers (timestamp, sourc

Date: Tue, 22 Jun 2010 16:31:24 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4887

--- Comment #11 from tieuthunhi <tieuthunhi@xxxxxxxxxxx> 2010-06-22 16:31:23 PDT ---
(In reply to comment #3)
> Hi,
> 
> 1. Do you need to add another hard-wired column for the gigamon time?  I think
> this should be fetched from the Gigamon Header and presented in a custom
> column.  This way we do not need to handle this time in the frame dissector,
> column utils and a lot of other places.
> 
> 2. This patch contains a lot of whitespace changes, which makes it hard to
> read.  This should be separated in its own patch if this is a whitespace fix.

You are right, I could use a custom column.  I tried and it sorts ok.  As for
the white spaces, sorry, my editor is messing up the white spaces, and my diff
has -b option so I didn't catch that.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.