Wireshark-bugs: [Wireshark-bugs] [Bug 4756] "Apply as Filter" fails on FT_ABSOLUTE_TIME, ABSOLUT

Date: Tue, 11 May 2010 12:18:17 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4756

--- Comment #1 from Guy Harris <guy@xxxxxxxxxxxx> 2010-05-11 12:18:15 PDT ---
As the comment in construct_match_selected_string() in epan/proto.c says:

        /*
         * XXX - we can't use the "val_to_string_repr" and "string_repr_len"
         * functions for FT_UINT and FT_INT types, as we choose the base in
         * the string expression based on the display base of the field.
         *
         * Note that the base does matter, as this is also used for
         * the protocolinfo tap.
         *
         * It might be nice to use them in "proto_item_fill_label()"
         * as well, although, there, you'd have to deal with the base
         * *and* with resolved values for addresses.
         *
         * Perhaps we need two different val_to_string routines, one
         * to generate items for display filters and one to generate
         * strings for display, and pass to both of them the
         * "display" and "strings" values in the header_field_info
         * structure for the field, so they can get the base and,
         * if the field is Boolean or an enumerated integer type,
         * the tables used to generate human-readable values.
         */

This is another case where we need two val_to_string routines - we now display
time zone information for time stamps (to make it clearer what type of time it
is), but that shouldn't be in the filter string.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.