Wireshark-bugs: [Wireshark-bugs] [Bug 4413] Improve bitview display

Date: Fri, 30 Apr 2010 09:08:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.r.mathieson@googlema
                   |                            |il.com

--- Comment #11 from Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx> 2010-04-30 09:08:02 PDT ---
I like the bitview display selecting only the affected bits, but notice that it
doesn't work when bits were added using proto_tree_add_bits_ret_val().

I had a quick look at the code, and the mask used is taken from
finfo->hfinfo->bitmask (in packet_hex_print()).  proto_tree_add_bits_ret_val()
only works when (hf_field->bitmask != 0).

We could work out the bitmask in proto_tree_add_bits_ret_val(), but I'm not
sure where it could be stored for packet_hex_print() to pick up and use
later...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.