https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4703
Bill Meier <wmeier@xxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #8 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-04-22 18:52:22 EDT ---
(In reply to comment #6)
> Created an attachment (id=4566)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4566) [details]
> An updated SVN patch file for TRILL
>
> One Question
> "4. Just do a col_set_str(...,COL_PROTOCOL,...) at the beginning iso a
> col_clear."
>
> I have deleted the col_clear but as you can see on line 145 that is where I do
> the col_set_str. I did this since TRILL encapsulates Ethernet data and I
> thought it was logical to still have it show up as TRILL. Therefore we append
> to the end of the COL_INFO after the eth dissector has been called. Is this
> consistent with what has been done in the past? Should I also set the
> COL_INFO/COL_PROTOCOL at the beginning in case we reach an exception?
>
I believe the convention is that normally the packet-list protocol and info
columns show information for the "highest-level" (innermost) protocol rather
than trying to show info about intermediate/encapsulating protocols.
(Note that a number of the packets in your capture file have 802.1Q
encapsulation ...).
So: I think the correct way would be at the beginning to do
col_set_str(...,COL_PROTOCOL, ...)
col_clear(...,COL_INFO)
and remove the col_... calls after the call_dissector(...).
Also: Since there are no preferences, the #include <prefs.h> is not needed.
Other than this the code looks good.
If you are OK with the above, you can just let me know and I'll commit the
dissector with the changes as above.
As a followup it would be much appreciated if you would add a page for the
TRILL protocol to the Wireshark Wiki (wiki.wireshark.org).
See: http://wiki.wireshark.org/HowToEdit
and http://wiki.wireshark.org/ProtocolReference
Thanks !!
PS: which EMail address should appear in the Wireshark "AUTHORS" file ?
<david.bond [AT] iol.unh.edu> or
<mokon [AT] mokon.net>
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.