https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4546
Summary: Enchancement ISAKMP dissector (IKEv1 / IKEv2)
Product: Wireshark
Version: unspecified
Platform: Other
OS/Version: All
Status: NEW
Severity: Enhancement
Priority: Low
Component: Wireshark
AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
ReportedBy: alexis.lagoutte@xxxxxxxxx
Created an attachment (id=4347)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4347)
First patch... for review !
Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Enchancement ISAKMP dissector (IKEv1 / IKEv2)
* Rework sub dissect...
* use more proto_tree_add_item and less proto_tree_add_text ! ;)
* Updates lot of value from IANA
* http://www.iana.org/assignments/ipsec-registry
* http://www.iana.org/assignments/isakmp-registry
* http://www.iana.org/assignments/ikev2-parameters
About the type of code
else if (payload_length > length) {
proto_tree_add_text(ntree, tvb, 0, 0,
"Payload (bogus, length is %u, greater than
remaining length %d",
payload_length, length);
return;
the better solution is using Expert Info ?
The code is not finished, but it is possible to get a review ? (to known if is
is good..)
TODO :
Cleanup & Rework dissect_transform2, dissect_enc, dissect_payload,
dissect_isakmp...
The code is fuzzed and some regression test with IKEv2 decryption (no found
info to test IKEv2 decryption)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.