Wireshark-bugs: [Wireshark-bugs] [Bug 3917] tvb_new_real_data is prone to memory leak.

Date: Tue, 12 Jan 2010 13:14:56 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

--- Comment #3 from didier gautheron <dgautheron@xxxxxxxx> 2010-01-12 13:14:53 PST ---
(In reply to comment #2)
Hi,
In my understanding:

> Committ revision 31499.
> Leaves this unfixed, more elaboration on the possible leaks would help:
> ./asn1/kerberos/packet-kerberos-template.c
> may leak memory, not all code paths call tvb_free(encr_tvb).
in decrypt_krb5_data(), tvb_free is not called at the end of the loop

> 
> ./epan/dissectors/packet-dcp-etsi.c
> surely leak tvb structure memory.
in dissect_pft_fec_detailed()
dummytvb is never freed.

> 
> ./epan/dissectors/packet-ssl-utils.c
> leak tvb structure memory.
Tvbs allocated in ssl_add_record_info are never freed, only the tvb payload is.
Not easy to fix.

> 
> ./epan/dissectors/packet-nfs.c
> leak tvb structure memory.
tvbs allocated in store_nfs_file_handle() are never freed, only the payload.

> 
> ./epan/dissectors/packet-rtmpt.c
> may leak memory, anyway it uses tvb_composite_append() so it surely broken.
> 
> ./epan/dissectors/packet-syslog.c
> leak memory.
mtp3_tvb is never freed.

> 
> ./plugins/asn1/packet-asn1.c
> leak and dissect a tvb buff in proto_reg_handoff() outside a TRY block.
Not sure about the leak maybe I made a mistake.

proto_reg_handoff_asn1() call read_asn1_type_table() which use tvb functions
for decoding data from a file but proto_reg_handoff is not inside a TRY CATCH
block thus tvb functions could throw uncaught exceptions.

Didier

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.