Wireshark-bugs: [Wireshark-bugs] [Bug 4363] New: wireshark decodes kerberos AS-REQ PADATA incorr

Date: Tue, 29 Dec 2009 05:44:45 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4363

           Summary: wireshark decodes kerberos AS-REQ PADATA incorrect
           Product: Wireshark
           Version: 1.2.5
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: hadar@xxxxxx


Created an attachment (id=4102)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4102)
kerberos AS request

Build Information:
Version 1.2.5 (SVN Rev 31296)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.2, with GLib 2.20.3, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8,
with c-ares 1.6.0, with Lua 5.1, with GnuTLS 2.8.1, with Gcrypt 1.4.4, with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Dec 17 2009), with
AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.1.1
(packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch 1_0_rel0b
(20091008), GnuTLS 2.8.1, Gcrypt 1.4.4, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
AS-REQ, PADATA type 'ff' - PA-PROV-SRV-LOCATION (need to be -1) is decoded as
'4294967295'

from the source code: packet-kerberos.c
#define KRB5_PA_PROV_SRV_LOCATION      255    /* packetcable stuff */
but the type of padata (krb_PA_DATA_type) is define as FT_UINT32
in the function there is a comment that it is single byte only.

dissect_krb5_PA_DATA_type(proto_tree *tree, tvbuff_t *tvb, int offset,
asn1_ctx_t *actx _U_)
{
    offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset,
hf_krb_PA_DATA_type, &krb_PA_DATA_type);
    krb_PA_DATA_type&=0xff; /*this is really just one single byte */

    if(tree){
        proto_item_append_text(tree, " %s",
            val_to_str(krb_PA_DATA_type, krb5_preauthentication_types,
            "Unknown:%d"));
    }
    return offset;
}

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.