Wireshark-bugs: [Wireshark-bugs] [Bug 4152] New dissector for LTP

Date: Sun, 1 Nov 2009 21:52:55 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4152


Mithun Roy <mithunroy13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3849|review_for_checkin?         |
               Flag|                            |
Attachment #3849 is|0                           |1
           obsolete|                            |
   Attachment #3883|                            |review_for_checkin?
               Flag|                            |




--- Comment #6 from Mithun Roy <mithunroy13@xxxxxxxxx>  2009-11-01 21:52:52 PDT ---
Created an attachment (id=3883)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3883)
Ltp dissector, with suggested changes, take 2

Changes made from the previous patch.
- Got rid of the packet-ltp.h header file, because there were only a few define
statements. Added the define statements in packet-ltp.c. 
- Added the {0, NULL} tuple at the end of all the value_string variable.
- Removed the 'if(tree)' test.
- Changed a few proto_tree_add_uint_format() to
proto_tree_add_uint_format_value()
but I had to leave a few of them as proto_tree_add_uint_format(), because the
field name also needs to be formatted in some cases.
- The array declarations now have integral constant expression for size instead
of variables. 


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.