https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4014
Summary: ICMP: Add ID and seq # to Info column
Product: Wireshark
Version: SVN
Platform: All
URL: http://en.wikipedia.org/wiki/Ping
OS/Version: All
Status: NEW
Severity: Enhancement
Priority: Medium
Component: Wireshark
AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
ReportedBy: christopher.maynard@xxxxxxxxx
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3657| |review_for_checkin?
Flag| |
Created an attachment (id=3657)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3657)
Patch to display ICMP ID and seq # in Info column.
Build Information:
SVN 29893
--
This trivial patch merely displays the ICMP ID and sequence # in the Info
column.
Additional information could be displayed as well, similar to what Ping
displays. For example:
1) On Windows ping displays "bytes=XX". I was going to add that to the Info
column display as well using tvb_reported_length_remaining(); however, I guess
that probably wouldn't work too well in the case of fragmented packets, so I
decided not to add it.
2) On Linux, ping displays "ttl=XX". Displaying the TTL (or Hop count)
requires passing that information from the IP dissector to the ICMP dissector.
That would either require adding that information to the already large
packet_info struct or use of private_data to pass it. There have been
discussions about the use of packet_info, and the bottom line is that I'm not
sure what the best way is to pass data from one dissector to another, so I
didn't add that either. (See
http://www.wireshark.org/lists/wireshark-dev/200903/msg00001.html for one such
discussion.)
3) Both Windows and Linux ping display RTT as "time=XX". For that,
request/response tracking is probably the best method, as mentioned here:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3950#c5. Currently I don't
have the time to implement this though and I don't know when I will.
Anyway, this simple patch at least eliminates the need for custom column(s) to
display the ID and/or seq #.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.