https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2688
--- Comment #22 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2009-09-13 14:52:40 PDT ---
It's been a while...
This patch really needs:
1) to be re-organized (put proto_reg and friends at the bottom of the file,
like all other dissectors, put the hf_ and ett_ arrays in proto_reg, like all
other dissectors).
2) to have some sub-functions. There's a fair amount of repeated code and the
one-big-function thing just doesn't work.
3) There's an awful lot of hard-coded numbers throughout (like "payloadlength -
38"). There should be a better way.
4) Now that the dissector is heuristic, all the port number (and preference
registration) can be done away with.
I tried reworking the code but it got to be too much.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.