Wireshark-bugs: [Wireshark-bugs] [Bug 3816] TShark and fuzz-test do not detect dissector asserts

Date: Fri, 7 Aug 2009 16:15:58 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3816


Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wmeier@xxxxxxxxxxx




--- Comment #7 from Bill Meier <wmeier@xxxxxxxxxxx>  2009-08-07 16:15:53 PDT ---
OK: I've done the following:

1. Changed tshark so that it will output WARNING level log messages to stderr
when running with default preferences. 

(This means that DISSECTOR_BUG & etc messages from tshark will now appear on
stderr since they are WARNING level log messages).

(tshark was changed to use the value of the "console_log_level" preference to
determine which level(s) of log messages are to be output to stderr).

The default value for this preference is to output ERROR, CRITICAL & WARNING
messages.

This is a tshark behavior change. Previously WARNING messages were ignored.

If this change ends up making tshark output too "noisy" then plan B might be to
implement a log_level preference specifically for tshark
(tshark_console_log_level ?). The default for that would then be as before for
tshark: ignore WARNING messages.

2. Given the above change, fuzz-test should now detect DISSECTOR_BUGs and
failed DISSECTOR_ASSERTs when it searches the stderr output file.

I fixed the WIRESHARK_ABORT_ON_DISSECTOR_BUG mechanism in fuzz-test so it would
work as desired; I then decided to disable the feature. My sense is that it's
more useful to get some info from the stderr file than to force a core dump via
an ABORT (which results in no information in the stderr file).

I'll leave this bug open for now until we see how things work out.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.