Wireshark-bugs: [Wireshark-bugs] [Bug 3786] New: NDMP fragmentation fails when final fragment is

Date: Wed, 29 Jul 2009 12:40:31 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3786

           Summary: NDMP fragmentation fails when final fragment is very
                    small
           Product: Wireshark
           Version: SVN
          Platform: x86
        OS/Version: Windows XP
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: chcosta75@xxxxxxxxxxx



Chris Costa <chcosta75@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3428|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=3428)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3428)
Patch for small NDMP fragment problem

Build Information:
TShark 1.3.0-CCOSTA

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GLib 2.20.3, with WinPcap (version unknown), with libz 1.2.3,
without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8, with c-ares
1.6.0,
with Lua 5.1, without Python, with GnuTLS 2.8.1, with Gcrypt 1.4.4, with MIT
Kerberos, with GeoIP.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, GnuTLS 2.8.1,
Gcrypt 1.4.4.

Built using Microsoft Visual C++ 9.0 build 30729
--
I encountered a situation where the final fragment of an NDMP PDU was very
small, and fragment reassembly was failing.  The check_ndmp_rm function was
incorrectly assuming that any fragment less than 24 bytes (the size of the NDMP
header) was invalid, but that clearly isn't a valid check due to these
circumstances.

I created a patch that alters this check so that NDMP fragmentation will work
correctly in this situation.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.