Wireshark-bugs: [Wireshark-bugs] [Bug 3766] New: BACnet Action property not decoded correctly.

Date: Wed, 22 Jul 2009 07:08:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3766

           Summary: BACnet Action property not decoded correctly.
           Product: Wireshark
           Version: SVN
          Platform: All
               URL: http://kargs.net/captures/
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: steve@xxxxxxxxx



Steve Karg <steve@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3381|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=3381)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3381)
packet-bacapp.c.patch

Build Information:
wireshark 1.3.0 (SVN Rev 29135)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.9, with GLib 2.16.6, with libpcap 0.9.8, with libz
1.2.3.3, without POSIX capabilities, without libpcre, without SMI, without
c-ares, without ADNS, without Lua, without Python, with GnuTLS 2.0.4, with
Gcrypt 1.2.4, with MIT Kerberos, without GeoIP, without PortAudio, without
AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.24-24-generic, with libpcap version 0.9.8, GnuTLS 2.0.4,
Gcrypt 1.2.4.

Built using gcc 4.2.4 (Ubuntu 4.2.4-1ubuntu4).

--
Corrected the decoding of BACnet Action property value, which is used in the
Loop object and the Command object, is decoded two different ways.  

Refactored the BACnet property value function which was used in several places
in the packet-bacapp dissector.

Validated solution, and fuzz tested overnight.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.