Wireshark-bugs: [Wireshark-bugs] [Bug 3736] PATCH to packet-bacapp

Date: Wed, 15 Jul 2009 05:39:37 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3736


Stig Bjørlykke <stig@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3342|review_for_checkin?         |review_for_checkin-
               Flag|                            |




--- Comment #4 from Stig Bjørlykke <stig@xxxxxxxxxxxxx>  2009-07-15 05:39:35 PDT ---
(From update of attachment 3342)
In this code you can get a index outside the array:

static const gint MaxAPDUSize [] = { 50,128,206,480,1024,1476 };
  bacapp_apdu_size = tvb_get_guint8(tvb, offset + 1) & 0x0f;
  int min = MaxAPDUSize[bacapp_apdu_size];

Also:
- Remove C++ comments


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.