Wireshark-bugs: [Wireshark-bugs] [Bug 3378] New Dissector: Host Identity Protocol

Date: Tue, 2 Jun 2009 08:11:21 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3378


Stig Bjørlykke <stig@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3024|review_for_checkin?         |review_for_checkin+
               Flag|                            |




--- Comment #9 from Stig Bjørlykke <stig@xxxxxxxxxxxxx>  2009-06-02 08:11:18 PDT ---
(From update of attachment 3024)
Committed revision 28596 with a lot of changes.  Please check!

- Adjusted location of "Checksum" and "HIP Controls", as they seems to have
switched place in the bytes window
- Rewrote some proto_tree_add_uint -> proto_tree_add_item (some still remain)
- Rewrote to not use tvb_memcpy()
- Corrected some proto_tree_add_item's as the format seems to be big-endian
- Terminate ALL value_string's with { 0, NULL }
- No need to zero-terminate value_string strings.
- Removed call to check_col()
- Removed some prototypes
- Removed unused hf_hip_tlv_id, hf_hip_res and hf_hip_tlv_enc_iv (please check)
- Rewrote some C++ comments


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.