https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3226
Gerald Combs <gerald@xxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #2705|review_for_checkin? |
Flag| |
Attachment #2705 is|0 |1
obsolete| |
Attachment #3036| |review_for_checkin+
Flag| |
AssignedTo|wireshark-bugs@xxxxxxxxxxxxx|gerald@xxxxxxxxxxxxx
Status|NEW |ASSIGNED
--- Comment #3 from Gerald Combs <gerald@xxxxxxxxxxxxx> 2009-05-22 14:07:33 PDT ---
Created an attachment (id=3036)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3036)
"tvb_length(tvb) - offset" -> "tvb_length_remaining(tvb, offset)"
I tried downloading the sample capture file from the wiki, an it appears to be
empty. Can you re-upload it or attach it here?
Also, I noticed that the dissector had a lot of instances of
tvb_length(tvb) - offset
It's more correct to use
tvb_length_remaining(tvb, offset)
An updated version of packet-omron_fins.c is attached. Can you take a look at
it?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.