Wireshark-bugs: [Wireshark-bugs] [Bug 3467] Memcache Textual Protocol dissector patch

Date: Tue, 19 May 2009 11:39:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3467





--- Comment #11 from Rama Chitta <rama@xxxxxxxxx>  2009-05-19 11:39:05 PDT ---
> (In reply to comment #8)
> > You have moved OP_GET and added OP_GETS, OP_CAS and OP_VERBOSE.  From which
> > standard does this values come from?  The Memcache binary draft does not have
> > this values.

Hi Stig,

The reason I added three additional commands was because the text protocol has
"gets", "cas" and "verbosity" commands that the Binary protocol does not have. 

I intend to add them after all the binary protocol commands are listed
something like: 

/* Command Opcodes */
#define OP_GET                0x00
#define OP_SET                0x01
#define OP_ADD                0x02
#define OP_REPLACE            0x03
#define OP_DELETE             0x04
#define OP_INCREMENT          0x05
#define OP_DECREMENT          0x06
#define OP_QUIT               0x07
#define OP_FLUSH              0x08
#define OP_GET_Q              0x09
#define OP_NO_OP              0x0A
#define OP_VERSION            0x0B
#define OP_GET_K              0x0C
#define OP_GET_K_Q            0x0D
#define OP_APPEND             0x0E
#define OP_PREPEND            0x0F
#define OP_STAT               0x10
#define OP_SET_Q              0x11
#define OP_ADD_Q              0x12
#define OP_REPLACE_Q          0x13
#define OP_DELETE_Q           0x14
#define OP_INCREMENT_Q        0x15
#define OP_DECREMENT_Q        0x16
#define OP_QUIT_Q             0x17
#define OP_FLUSH_Q            0x18
#define OP_APPEND_Q           0x19
#define OP_PREPEND_Q          0x1A

/* NEW ADDITIONS */
#define OP_GETS               0x1B
#define OP_CAS                0x1C
#define OP_VERBOSE            0x1D

that should not be a problem right until the protocol draft changes?  or you
think they should be separate and we should just deal with them?

Thanks


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.