Wireshark-bugs: [Wireshark-bugs] [Bug 3452] New: GSM DTAP: incorrect display of Suppl. Service M

Date: Wed, 6 May 2009 13:11:40 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3452

           Summary: GSM DTAP: incorrect display of Suppl. Service Message
                    Type in SVN revision 28281
           Product: Wireshark
           Version: SVN
          Platform: x86
        OS/Version: SuSE
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: rspmn@xxxxxxxx


Created an attachment (id=2982)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2982)
Sample .pcap

Build Information:
wireshark 1.0.7

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.14.4, with GLib 2.18.2, with libpcap 0.9-PRE-CVS, with
libz
1.2.3, without POSIX capabilities, with libpcre 7.8, without SMI, without ADNS,
with Lua 5.1, with GnuTLS 2.4.1, with Gcrypt 1.4.1, without Kerberos, without
PortAudio, without AirPcap.

Running on Linux 2.6.27.21-0.1-pae, with libpcap version 0.9-PRE-CVS.

Built using gcc 4.3.2 [gcc-4_3-branch revision 141291].

vs.
SVN revision 28281.

--
A Supplementary Service message (PD 11) which contains a non-zero sequence
number (like the Register from the attached .pcap below, decode User DLT 0
as gsm_a_dtap) is displayed correctly by Wireshark 1.0.7 as

    Protocol Discriminator: Non call related SS messages
        0... .... :  TI flag: allocated by sender
        .001 .... :  TIO: 1
        .... 1011 = Protocol discriminator: Non call related SS messages (11)
    Message Type Register
    Facility

while it is displayed by Wireshark SVN revision 28281 as

   Protocol Discriminator: Non call related SS messages
        0... .... :  TI flag: allocated by sender
        .001 .... :  TIO: 1
        .... 1011 = Protocol discriminator: Non call related SS messages (11)
    DTAP Non call Supplementary Service Message Type: Unknown (0xbb)
    Facility

as the sequence number handling does not seem to be performed for PD 11.

With the proposed patch below the same message is displayed as:

    Protocol Discriminator: Non call related SS messages
        0... .... :  TI flag: allocated by sender
        .001 .... :  TIO: 1
        .... 1011 = Protocol discriminator: Non call related SS messages (11)
    10.. .... = Sequence number: 2
    ..11 1011 = DTAP Non call Supplementary Service Message Type: Register
(0x3b)
    Facility


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.