Wireshark-bugs: [Wireshark-bugs] [Bug 3408] Add IKEv2 decryption support

Date: Wed, 15 Apr 2009 08:07:20 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3408





--- Comment #4 from Naoyoshi Ueda <piyomaru3141@xxxxxxxxx>  2009-04-15 08:07:18 PDT ---
(In reply to comment #3)
> (From update of attachment 2930 [details])
> Why move this currently clean dissector to the dirty list?
> 

Without this modification, compilation will fail because of the following
warning:
packet-isakmp.c: In function proto_register_isakmp:
packet-isakmp.c:3884: : dereferencing type-punned pointer will break
strict-aliasing rules

The following is around the 3884th line of packet-isakmp.c. 
There appears to be a problem with the 5th arg of uat_new().
3880   ikev2_uat = uat_new("IKEv2 Decryption Table",
3881       sizeof(ikev2_uat_data_t),
3882       "ikev2_decryption_table",
3883       TRUE,
3884       (void**)&ikev2_uat_data,
3885       &num_ikev2_uat_data,
3886       UAT_CAT_CRYPTO,
3887       "ChIKEv2DecryptionSection",
3888       NULL,
3889       ikev2_uat_data_update_cb,
3890       NULL,
3891       ikev2_uat_flds);

I tried to fix the warning, but I couldn't. So I checked the other dissectors
that call uat_new (packet-k12.c, packet-pres.c, packet-sccp.c, packet-snmp.c
and packet-user_encap.c), and found that all of which also cause the same
warning and are in the dirty list (DIRTY_ASN1_DISSECTOR_SRC and
DIRTY_DISSECTOR_SRC).

That's why I conclude there's no way to avoid the warning at the moment and I
moved the dissector to the dirty list.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.