Wireshark-bugs: [Wireshark-bugs] [Bug 3369] New: SMPP TLV tag value_strings

Date: Sat, 28 Mar 2009 12:58:02 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3369

           Summary: SMPP TLV tag value_strings
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: sarkar.abhik@xxxxxxxxx



Abhik Sarkar <sarkar.abhik@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2891|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2891)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2891)
Patch to implement a TODO from the previous enhancement for this dissector

Build Information:
Version 1.1.4 (SVN Rev 27876)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.0, with GLib 2.20.0, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8,
with c-ares 1.6.0, with Lua 5.1, with GnuTLS 2.6.4, with Gcrypt 1.4.4, with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Mar 28 2009), with
AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, GnuTLS 2.6.4,
Gcrypt 1.4.4, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
This patch fixes a TODO added by Richard when he checked-in an enhancement in
revision 27780 (http://anonsvn.wireshark.org/viewvc?view=rev&revision=27780). 

I have chosen _not_ to use the value_string array in the header field for the
tag because the information appears in too many places - once in the sub-tree
and again once in the field which displays the value. Displaying the tag name
again in the tag field would make the same information appear three times in
four lines.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.