Wireshark-bugs: [Wireshark-bugs] [Bug 3009] new ismacryp dissector

Date: Thu, 26 Mar 2009 03:03:10 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3009





--- Comment #17 from David Castleford <david.castleford@xxxxxxxxxxxxxxxxxx>  2009-03-26 03:03:10 PDT ---
(In reply to comment #14)
> Committed: SVN #27840
> 
> I've made some (more or less cosmetic) changes (formatting, use TRUE/FALSE for
> booleans, remove unneeded includes, etc).
> 
> Please review to make sure I haven't broken anything.
>

thanks, I've done a quick test run and it seems to behave as expected.

> As discussed: ToDo: determine how to make SDP session description attributes
> (for an ismacryp session) available to the ismacryp dissector. (I'll do some
> research on this).
>
I have to use conversations. I'm working on SDP decode_sdp_fmtp adding an
ISMACryp section to handle ISMACryp parameters (same names as those in
preferences). It looks like I put all of those in an struct ismacryp_info. I'll
go on existing examples and will let you know if I have any problems (I'm sure
I will). Presumably I can access these from the ISMACryp dissector if a
conversation is found.

> Thanks !
> 
thank you!
(In reply to comment #15)
> Also: Could you please create a Wireshark Wiki page for ismacryp as you did for
> simulcrypt.
> 
> Thanks
> 
Done


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.