Wireshark-bugs: [Wireshark-bugs] [Bug 2504] Slow response when using Expert Info Composite

Date: Wed, 11 Mar 2009 13:47:56 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2504


Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darkjames@xxxxxxxxxxxxxxxx




--- Comment #4 from Jakub Zawadzki <darkjames@xxxxxxxxxxxxxxxx>  2009-03-11 13:47:54 PDT ---
(In reply to comment #3)
> Created an attachment (id=1747)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=1747) [details]
> quick and dirty patch to make expert_tapdata_t structs consistent
> 
> Hello All,
> 
> I was running Wireshark within valgrind and spotted one issue when using the
> Expert Info Composite window.
> 
> Both of the Expert Info dialogs define and use a typedef called
> expert_tapdata_t.  One version of the typedef is defined in the expert_dlg.c
> file, while the other is defined in expert_comp_table.h.
> 
> The typedef defined in expert_dlg.c includes 12 fields whereas the one defined
> in expert_comp_table.h has 11 fields.  Within expert_dlg.c's typedef the 3rd
> field is a 'GtkCList *table'.  The 'GtkCList *table' field is not present in
> expert_comp_table.h's typedef.
> 
> Assuming that GtkClist pointers are 4 bytes in length, any etd variables
> allocated within expert_comp_init() at expert_comp_dlg.c:187, will be four
> bytes smaller (44 bytes) then etd variables allocated within expert_dlg_init()
> at expert_dlg:493 (48 bytes).
> 
> Both expert info dialogs share some common tap functions, which reference
> fields defined inside the etd variables.  valgrind alerted to the fact that
> expert_dlg's expert_dlg_draw() was attempting to access the variable
> "etd->severity_report_level" which was beyond the end of the allocated block of
> data.  This particular etd structure was allocated from within
> expert_comp_init().

It's still there, could someone fix it?


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.