Wireshark-bugs: [Wireshark-bugs] [Bug 3313] New: BACnet MS/TP checksums

Date: Sat, 7 Mar 2009 07:40:49 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3313

           Summary: BACnet MS/TP checksums
           Product: Wireshark
           Version: SVN
          Platform: PC
               URL: http://kargs.net/captures/cimetrics_mstp.pcap
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: steve@xxxxxxxxx



Steve Karg <steve@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2826|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2826)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2826)
packet-mstp.c.patch

Build Information:
wireshark 1.1.3 (SVN Rev 27642)

Copyright 1998-2009 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.9, with GLib 2.16.6, with libpcap 0.9.8, with libz
1.2.3.3, without POSIX capabilities, without libpcre, without SMI, without
c-ares, without ADNS, without Lua, with GnuTLS 2.0.4, with Gcrypt 1.2.4, with
MIT Kerberos, without GeoIP, without PortAudio, without AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.24-23-generic, with libpcap version 0.9.8, GnuTLS 2.0.4,
Gcrypt 1.2.4.

Built using gcc 4.2.4 (Ubuntu 4.2.4-1ubuntu3).

--
When I enabled the checksum validate in packet-mstp.c, a capture locks up
Wireshark when the length is greater than 255. Corrected the size of the
for-loop counter declaration, and added expert info and a checksum_bad flag.
Added the MS/TP checksum bad setting to Checksum color filter. Fuzz tested with
BACnet MS/TP captures.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.