Wireshark-bugs: [Wireshark-bugs] [Bug 3174] New: DNP 3.0 dissector is missing commands

Date: Mon, 5 Jan 2009 15:58:33 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3174

           Summary: DNP 3.0 dissector is missing commands
           Product: Wireshark
           Version: 1.0.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: roy@xxxxxxxxxxxxxxxx



Roy M. Silvernail <roy@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2639|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2639)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2639)
Patch to add missing commands and default variation decodes to the DNP 3.0
dissector

Build Information:
Version 1.0.0

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.9, with GLib 2.16.1, with libpcap 0.9.8, with libz
1.2.3.3, with POSIX capabilities (Linux), with libpcre 7.4, without SMI, with
ADNS, with Lua 5.1, with GnuTLS 2.0.4, with Gcrypt 1.2.4, with MIT Kerberos,
with PortAudio V19-devel (built Mar 12 2008), without AirPcap.

Running on Linux 2.6.24-22-generic, with libpcap version 0.9.8.

Built using gcc 4.2.3 (Ubuntu 4.2.3-2ubuntu7).

--
Several command codes were missing, causing the dissector to abort decoding
on valid packets.  Those commands have been added in the attached patch.

The semantics of Variation 0 have been cleaned up.  Variation 0 is the
"Default Variation".  It is used only in Master -> Slave read commands
to request the data in whatever variation the Slave is configured to use by
default. Decoder strings have been added to the Binary Output and
Analog Output objects (10 and 40) so that group read commands for 
Variation 0 will decode properly.

This patch was not fuzzed, as it only adds additional decode strings.

Thank $DAYJOB I have a current copy of the DNP spec. :)


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.