https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3166
--- Comment #3 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2009-01-03 04:03:11 PDT ---
When looking at packet-gsm_um.c I noticed that first you:
+ if( !pinfo->pseudo_header->gsm_um.uplink ) {
then:
+ uplink = ....;
+ downlink = ....;
but then:
+ freq = pinfo->pseudo_header->gsm_um.uplink ? uplink :
downlink;
This results in freq is always downlink, so why bother with uplink? Or is that
intentional?
Due to the test before this line:
+ else if( /*arfcn >= 0 &&*/ arfcn <= 124 ) { /* guint is always >= 0! */
this line collapses into:
+ else if( arfcn == 0 ) {
Overlapping regions are a pain, since now E-GSM 900 is mostly hidden behind
P-GSM 900.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.