Wireshark-bugs: [Wireshark-bugs] [Bug 3020] [epan/dissectors/packet-tacacs.c:871]: Memory leak:

Date: Thu, 30 Oct 2008 17:38:40 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3020


Stephen Fisher <stephentfisher@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Stephen Fisher <stephentfisher@xxxxxxxxx>  2008-10-30 17:38:39 PDT ---
(In reply to comment #4)
> Yes I am. I have scanned several open source projects with it:
> http://cppcheck.wiki.sourceforge.net/

Ok.

> You are also mentioned there:
> http://cppcheck.wiki.sourceforge.net/found_bugs

Lucky us :).  How do we get unlisted once the items found are fixed?

> It is pretty good also, e.g. assuming that I made no mistakes when checking
> these (I did check every finding manually to avoid possible extra work for
> you),

Thanks.

> cppcheck produced no false positives for your project. This is the whole output from it:
> 
> $ cppcheck --recursive > ../output.txt 
> [epan/dissectors/packet-giop.c:1488]: Memory leak: saved_repoid
> [epan/dissectors/packet-tacacs.c:871]: Memory leak: tacplus_data
> [gtk/follow_ssl.c:176]: Memory leak: follow_info
> [gtk/follow_udp.c:123]: Memory leak: follow_info
> [gtk/sctp_chunk_stat_dlg.c:328]: Memory leak: col_arrows
> [gtk/sctp_error_dlg.c:230]: Memory leak: col_arrows 

I just downloaded the latest version of cppcheck and checked all of the files
you reported.  Some of them didn't show any errors on my system.  Nevertheless,
I have/am fixing each of the ones you reported along with any others that jump
out at me.

As for this bug, the leaks in packet-tacacs.c for this bug have been fixed in
SVN revision 26636.  Thanks for your report!


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.