Wireshark-bugs: [Wireshark-bugs] [Bug 2798] New Dissector: IEEE C37.118 Synchrophasor Protocol

Date: Wed, 15 Oct 2008 06:41:43 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2798





--- Comment #13 from Jens Steinhauser <jens.steinhauser@xxxxxxxxxx>  2008-10-15 06:41:41 PDT ---
(In reply to comment #12)
> I took a quick look and have one comment: ports 4712 and 4713 aren't IANA
> registered so really this dissector should be "new style" meaning that does
> some heuristics to check if the packet handed to it belongs to it--and if not
> return FALSE.  (I probably won't have time to look/comment further.)

This initially was an new style dissector, but I changed the dissection routine
to return 'void' instead of 'int' when I started to use 'tcp_dissect_pdus()',
it doesn't support new style dissectors.

The heuristic is still there and one just has to replace all 'returns' with
'return offset' to change the dissector back to a new style dissector if
'tcp_dissect_pdus()' supports this in the future.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.