https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2840
Anders Broman <anders.broman@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anders.broman@xxxxxxxxxxxx
--- Comment #5 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2008-09-13 03:17:16 PDT ---
Just a few initial comments:
- Please change comments from Spanish to English:
+/* Constants relatives al camp, independentment de la posicio del camp en el
byte */
+/* Tipus U (Unnombered) */
- Please do the protocol Registration at the end of the file to be consistent
with the layout of other dissectors.
+void
+proto_register_iec104apci(void)
- Is it realy needed to copy the header to memmory?
+ asduh->AddrLow = tvb_get_guint8(tvb, 4);
- Is realy all the g_snprintf etc needed couldn't proto_tree_add_item() be used
instead?
/Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.