https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2825
--- Comment #6 from Stefan Monhof <stefan.monhof@xxxxxxxxxxxxxxx> 2008-08-24 08:41:10 PDT ---
(In reply to comment #2)
> (From update of attachment 2176 [details])
> here's something wrong... we are dereferencing a pointer in one line and
> testing for it in the following line.
>
> Either for good, it cannot be NULL and so the test in the following line is
> useless, or for bad it can actually be NULL and crash when derreferenced.
>
>
> @@ -863,8 +921,8 @@
>
> tag_full_name = "UnknownTagName";
>
> + tagname_value = *(guint8*)tagname;
> if ( tagname && string_length == 1 ) {
> - guint8 tagname_value = *(guint8*)tagname;
> /* lookup tagname */
> tag_full_name = val_to_str( tagname_value, kademlia_tags,
> tag_full_name );
> }
>
Uh, you're right. I've had added some information there, but later I moved them
to another function. It seems I forgot to change it back correctly.
I'll add a fix ontop of the actual revision.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.