Wireshark-bugs: [Wireshark-bugs] [Bug 2752] Add Ethernet Global Data dissector

Date: Thu, 31 Jul 2008 07:52:53 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2752





--- Comment #7 from Ryan Wamsley <wamslers@xxxxxxxxxxxxx>  2008-07-31 07:52:52 PDT ---
> Creating hidden items get you scorned by some of the developers. I understand you want to filter on these items, so just add these first, then add human readable item.

I'll just remove them.

> The thing with protocol analyzers is that they tend to expose every bit of the protocols, even (or should I say especially) when they are application
specific. Handing the data to the data dissector makes it possible for the user
to look at (the first part of) the data without begin forced to open the packet
bytes pane. That could just be enough for the power user, whose needs we try to
address.

I was totally misunderstanding you. I thought you wanted me to write a data
dissector specifically for this data. I see now that you want me to call the
existing data dissector.

I have implemented a different solution, borrowed from the enip dissector (the
cip/enip protocols accomplish the same ends as egd).  Let me know if you
approve.

> Your dissector should be added to the CLEAN_DISSECTOR_SRC symbol, not the dirty list.

Done

Thanks for your assistance


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.