https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1970
Anders Broman <anders.broman@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anders.broman@xxxxxxxxxxxx
--- Comment #56 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2008-07-30 07:47:00 PDT ---
Hi,
It's probably better to open a new bug with diffs towards the current SVN
and close the old ones.
Note on the dissectors:
I'd prefere a built in dissectors not plugins.
The files should be prefixed ipmi ( packet-ipmi-x.c )
Functions are probably better as:
dissect_ipmi_cmd_Set_LAN_Configuration_Parameters()
rather than
dissect_cmd_Set_LAN_Configuration_Parameters()
hf variables should be prefixed ipmi (ipmi_x).
Regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.