Wireshark-bugs: [Wireshark-bugs] [Bug 2453] segmentation fault with wslua script

Date: Fri, 16 May 2008 07:37:37 -0700 (PDT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2453





--- Comment #29 from Balint Reczey <balint.reczey@xxxxxxxxxxxx>  2008-05-16 07:37:36 PDT ---
(In reply to comment #24)
> > I think we should disable the outstanding stuff for now because it causes
> > random crashes and warn users not to keep references to buffers/trees/pinfos
> > from previous packets.
> 
> I do not thing relying on users not to do anything that crashes is a good
> solution at all.
> 
> I think you found the problem:
> 
> As you said We are NULLifying already removed objects for which if there was a
> __gc it would have being called.
> 
> We *do* need a __gc but not for freeing the resources (that's taken care
> elsewhere) but to remove the reference to the boxed object from the outstanding
> objects queue.
> 
> Luis
> 

I added __gc to TvbRange and it was not called while dissecting test2.pcap.

I think that __gc will not be called since our problem is that there are
references to the TvbRange.

I still don't see any simple solution for the crash apart from the attached
patches and a warning message.

An other approach would be marking the tvb/pinfo/tree structures and not
freeing them in Wireshark but from__gc.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.