http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2488
Abhik Sarkar <sarkar.abhik@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1719|review_for_checkin? |
Flag| |
Attachment #1719 is|0 |1
obsolete| |
Attachment #1748| |review_for_checkin?
Flag| |
--- Comment #5 from Abhik Sarkar <sarkar.abhik@xxxxxxxxx> 2008-04-28 05:37:19 GMT ---
Created an attachment (id=1748)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1748)
Revised patch
OK, I check ETSI ETS 300 133-3. According to section 8.2.5:
Operation Type (OT) 00 is "Enquiry Operation"
Operation Type (OT) 14 is "Message retrieval Operation"
For OT 00, according to sections 8.2.5.1.1 and 8.2.5.1.2 the SM field is only
present for a negative response. So, the original dissector was correct. Sorry
about the incorrect change.
For OT 14, the PDU is a bit complex and I think for now that we should keep the
original logic except for the changes regarding the statistics.
Unfortunately, I don't have any means of checking that part of the specs
because the SMSC generally deals with OT>=30, so I don't have access to PDUs
with these operations.
I am submitting a revised patch.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.