Wireshark-bugs: [Wireshark-bugs] [Bug 2497] New: RTP heuristic interferes with STUN/T38 portion

Date: Tue, 22 Apr 2008 15:08:39 -0700 (PDT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2497

           Summary: RTP heuristic interferes with STUN/T38 portion of
                    heuristic
           Product: Wireshark
           Version: 1.0.0
          Platform: All
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: randomkodemonkey@xxxxxxxxx



Peter Fuller <randomkodemonkey@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1731|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=1731)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1731)
Patch to move 5 lines of code down past the preference setting for how to
dissect the packet

Build Information:
Version 1.0.99 (SVN Rev 25106)

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.4, with GLib 2.14.6, with libpcap 0.9.8, with libz
1.2.3, without POSIX capabilities, with libpcre 4.5, with SMI 0.4.3, with ADNS,
with Lua 5.1, with GnuTLS 2.2.0, with Gcrypt 1.4.0, with MIT Kerberos, with
PortAudio V19-devel (built Mar  1 2008), without AirPcap.

Running on Darwin 8.11.1 (MacOS 10.4.11), with libpcap version 0.9.8.

Built using gcc 4.0.1 (Apple Computer, Inc. build 5367).
--
If a UDP packet is submitted to the RTP heuristic dissector with either odd src
or dst ports, the heuristic will correctly return FALSE.  However, that
interferes with the next few lines of code that can potentially treat version 0
RTP packets as either STUN or T38 depending on preference settings.

The attached patch simply moves the port value code down past the dissector
preference code.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.