Wireshark-bugs: [Wireshark-bugs] [Bug 2253] SNMP trap dissectors fails

Date: Mon, 21 Apr 2008 15:31:13 -0700 (PDT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2253





--- Comment #5 from LEGO <luis.ontanon@xxxxxxxxx>  2008-04-21 15:31:13 GMT ---
This is my closing comment to bug 664:

The code to handle VarBind is already convoluted, while I agree that It would
be nice to have an expert item marking such cases that would mean use different
code to handle every type of variable.

By using proto_tree_add_item I get all the "conforming" cases with very little
and straightforward code, if instead of that I'd be using proto_tree_add_xxx to
add the values and check for conformance the code would become as convoluted as
it was before the rewrite (or even more).

So, IMHO, while I agree this is a bug, The price to pay for fixing it is to
high for what we would get back.

----


One part of the bug persists, a negative BER integer value (one not starting
with 0) will be considered an unsigned (i.e. positive) integer made of as many
bytes.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.