Wireshark-bugs: [Wireshark-bugs] [Bug 2439] patch for tvb_get_bits16 not to read past end of buf

Date: Fri, 11 Apr 2008 20:16:14 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2439


Michael McCartney <mccart@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1668 is|0                           |1
           obsolete|                            |




--- Comment #4 from Michael McCartney <mccart@xxxxxxxxxxxxxxxxxx>  2008-04-11 20:16:13 GMT ---
Created an attachment (id=1670)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1670)
epan/tvbuff.c svn patch

Complete patch to fix tvb_get_bits16(), _bits32() and _bits64().

Wrote some sample dissector code for _bits16() case such 
that 11 bits spanned last three octets in tvb() (to test
the else case), ie., three fields consisting of 6 bits,
11 bits, and 7 bits for the last three octet.  

Got expected malformed error, then tried same code as in 
_bits64(), no malformed error but the calculated value was 
wrong.  Fixed that for all three function's else case.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.