Wireshark-bugs: [Wireshark-bugs] [Bug 1603] SMPP decodes validity_period field incorrectly

Date: Tue, 18 Mar 2008 15:09:12 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1603





--- Comment #7 from Jonica Keel <jonica.keel@xxxxxxx>  2008-03-18 15:09:07 GMT ---
(In reply to comment #0)
> Build Information:
> Version 0.99.5 (SVN Rev 20677)
> Copyright 1998-2007 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> Compiled with GTK+ 2.10.7, with GLib 2.12.7, with WinPcap (version unknown),
> with libz 1.2.3, with libpcre 6.4, with Net-SNMP 5.4, with ADNS, with Lua 5.1,
> with GnuTLS 1.6.1, with Gcrypt 1.2.3, with MIT Kerberos, with PortAudio
> PortAudio V19-devel, with AirPcap.
> Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0
> (packet.dll version 4.0.0.755), based on libpcap version 0.9.5, without
> AirPcap.
> Built using Microsoft Visual C++ 6.0 build 8804
> Wireshark is Open Source Software released under the GNU General Public
> License.
> Check the man page and http://www.wireshark.org for more information.
> --
> When decoding SMPP the validity_period field is incorrectly decoded
> (reproducible).  I've attached a capture that shows the SMPP submit_sm PDU
> where the validity period is set to 1 minute and 59 seconds (per SMPP 3.4
> section 7.1).  Wireshark reports the validity period as:
> Validity period: 943949300.000000000 seconds
> I suspect that it is decoding the ascii as hex.

(In reply to comment #6)
> The relative time definition in the current standard (5.0) looks like a sloppy
> copy/paste job to me. Even the text contains traces of the previous protocol. 
> Without the context of the MC this can't be converted into seconds. First of
> all the number of days may not be 0 (range is 1..31). Then there is no way to
> tell how many days are in a month. Should 1 month count for 30 days (=2592000
> s) or 31 days (=2678400 s)? Same goes for years, they leap.

This is true regarding the SMPP 5.0 spec, however for practical purposes the
Relative time value is only ever set using days, hours, minutes, or seconds. 
There is no SMS carrier that will hold messages longer than 3-7 days.  It would
be very helpful if Wireshark could decode those ranges.  As for months and
years some sort of default value (month=30 days and year=365 days) could be
applied if anyone actually populated those fields.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.