Wireshark-bugs: [Wireshark-bugs] [Bug 839] Inconsistent inclusion of CRLF/0d0a in SIP fields

Date: Sat, 15 Mar 2008 19:17:24 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=839


Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.r.mathieson@googlemai
                   |                            |l.com




--- Comment #6 from Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>  2008-03-15 19:17:19 GMT ---
(In reply to comment #5)
> I would argue that the CRLF should be part of each field--like it is with HTTP.
>  One good reason for this is so we can Copy (as bytes, text, etc.) and get the
> full line including the CRLF so we can copy/paste multiple lines without having
> to hit enter each time..
>

I agree, although there are bound to be times when you wish you had a line
without the separators.

> That being said, it appears the SIP dissector is now consistent in including
> the CRLF in the fields.  I checked all the lines in the attached capture
> (including the Status line) and they all had it.  Resolving this was Fixed (who
> knows when it was fixed, probably a long time ago).
> 

I think I may have fixed it, when debugging an application that
parsed/reassembled  SIP messages.  I wanted to click on the request/response
line/header of headers/body and see immediately in the status line how large
they were, including separators, so I could compare offsets sanely.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.