http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2205
--- Comment #4 from Jeff Morriss <jeff.morriss@xxxxxxxxxxx> 2008-02-25 17:58:44 GMT ---
This dissector would be our first heuristic Ethernet dissector (that I found
anyway). Adding it seems to slow down the loading of large (non-Hilscher)
captures by 2-4% for me because the Ethernet dissector always tries heuristic
dissectors first:
/*
* In case the packet is a non-Ethernet packet inside
* Ethernet framing, allow heuristic dissectors to take
* a first look before we assume that it's actually an
* Ethernet packet.
*/
if (dissector_try_heuristic(heur_subdissector_list, tvb, pinfo, parent_tree))
Are we OK with that? (It's not this dissector's fault: its heuristics should
be pretty efficient, but still calling them 100k times to load a capture file
takes a fair amount of time.)
Or should the Ethernet dissector also get a "Try heuristic dissectors first?"
preference (defaulted to FALSE)?
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.