http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2074
------- Comment #9 from jaap.keuter@xxxxxxxxx 2008-01-09 08:23 GMT -------
Looks much better. Now for some final cleanup.
Why use proto_tree_add_uint64()? FT_UINT64 is available as fieldtype for this.
You forgot to change the code adding AdditionalCode, VersionODCalling to the
tree.
Still there are header fields with the same text and blurb (ie, "LAN Redundancy
Put Information Error"). These blurbs can be cleared out.
Mind you, there's the new preference to use 'NULL, HFILL' i.s.o '"", HFILL' in
the header field, so to avoid allocation many empty string. Could you change
that as well.
When all this is done it is time to fuzztest this code. This way you can check
the robustness of the code against invalid protocol items. Collect all the
capture file you have of this protocol and run tools/fuzztest.sh on them. Let
it run for an hour and see if any problems show up.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.