http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2078
stephentfisher@xxxxxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Comment #4 from stephentfisher@xxxxxxxxx 2007-12-17 20:43 GMT -------
Thanks for regenerating the patch!
I made a few of minor changes to your code:
- Changed tcpinfo->ack to tcpinfo->lastackseq to more closely match the names
of the other ack number variables
- Removed the declaration of iSource on line 397 of packet-rtmpt.c since it
is an unused variable
- Removed static int hf_rtmpt_amf_object since it is unused
I saw the following comment in the code, could you create a Wiki page (at
http://wiki.wireshark.org/RTMPT) if you haven't already to include information
such as this. Otherwise, users may never know how it works without reading the
source :)
/* To avoid a too high rate of false positive, this heurisitics
only matches the protocol
from the first server response packet and not from the
client request packets before.
Therefore it is necessary to a "Decode as" to properly
decode the first packets */
I have committed your code as SVN revision 23902. Thanks for your
contribution!
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.