Wireshark-bugs: [Wireshark-bugs] [Bug 2084] dissector for Distributed Lock Protocol version 3

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 10 Dec 2007 06:57:57 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2084





------- Comment #4 from jaap.keuter@xxxxxxxxx  2007-12-10 06:57 GMT -------
Did you fuzztest this dissector? I think not.

All your value strings need to be terminated by {0, NULL} tuple.

  if (check_col(pinfo->cinfo, COL_INFO))
    col_set_str(pinfo->cinfo, COL_INFO, 
                val_to_str(h_cmd, 
                           dlm3_cmd, 
                           "packet-dlm3.c internal bug"));
This does not signify a internal bug, it's a sign the packet doesn't conform
the protocol spec.

Please use NULL for empty blurbs in header fields. So 'NULL, HFILL }},' i.s.o.
'"", HFILL }}'.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.