http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1995
stig@xxxxxxxxxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1126|review_for_checkin? |review_for_checkin+
Flag| |
------- Comment #2 from stig@xxxxxxxxxxxxx 2007-11-24 22:09 GMT -------
(From update of attachment 1126)
A few comments on this patch:
1. Do you have a sample capture to try?
2. I think this construction will crash wireshark if an illegal opcode matching
a NULL in the nfsv4_operation_ett list occurs:
newftree = proto_item_add_subtree(fitem,
*nfsv4_operation_ett[opcode - 3]);
I added a break if this occurs, please have a look if this is correct.
3. In dissect_nfs_deviceaddr4() you do not move the offset for
dissect_nfs_devices4().
I added this, please have a look if this is correct.
3. You have missed the default case in dissect_rpc_secparms4()
I added this.
Committed revision 23570.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.