Wireshark-bugs: [Wireshark-bugs] [Bug 2005] Visual Network format KO in Wireshark, OK in Etherea

Date: Wed, 21 Nov 2007 22:09:18 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2005


guy@xxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |james@xxxxxxxxxxxxxxxxxx
         OS/Version|Windows 2000                |All
           Platform|PC                          |All




------- Comment #2 from guy@xxxxxxxxxxxx  2007-11-21 22:09 GMT -------
This was a result of the change in

    http://www.wireshark.org/lists/wireshark-dev/200703/msg00410.html

which "corrects two long standing issues with the Visual Networks file type in
PPP and ML-PPP environments".

The problem is that, as the code to read Visual Network files says, "a file
with media type 22 may contain Cisco HDLC or PPP over HDLC".

The code before the change checked a per-packet "encapsulation hint" to
determine whether the packet is Cisco HDLC or PPP; the code after the change
uses a heuristic to guess whether a packet is Cisco HDLC or PPP.  The heuristic
doesn't handle the case where Address-and-Control-Field-Compression is
negotiated on, so that packets don't begin with 0xff 0x03.

I'll back out the change in question, and request sample files for the problems
that change claims to fix, to see whether it can be fixed in a fashion that
doesn't assume Address-and-Control-Field-Compression is always off for PPP.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.