Wireshark-bugs: [Wireshark-bugs] [Bug 1921] Additional preferences for sFlow

Date: Thu, 18 Oct 2007 15:10:46 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1921


acferen@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1048|                            |review_for_checkin?
               Flag|                            |




------- Comment #1 from acferen@xxxxxxxxx  2007-10-18 15:10 GMT -------
Created an attachment (id=1048)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1048&action=view)
Patch to add preferences for sFlow (disable sample dissection and/or analysis)

I left the default for dissect sample headers as TRUE because this was the
previous behavior.  Personally I think this should default to FALSE, but it is
a preference so I can set mine how I like :-).

I set the default for analyze header to FALSE.  The implicit default previously
was TRUE, but I think this was a bug.  I can't actually think of any situation
where it makes sense to set this value to TRUE, but I may be missing something.
 If anyone wants the old behavior they can set their preference back to TRUE.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.