Wireshark-bugs: [Wireshark-bugs] [Bug 1798] packet-d*.c display filter fields incorrectly named.

Date: Mon, 8 Oct 2007 00:26:27 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1798


richardv@xxxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from richardv@xxxxxxxxxxxxx  2007-10-08 00:26 GMT -------
I've applied part of this:

(In reply to comment #1)
> Created an attachment (id=859)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=859&action=view) [details]
> Patch covering all 5 packet-d*.c files.
> 
> packet-dcerpc-dssetup.c: Removed redundant dssetup from field name.

This file is autogenerated - I've not applied this part of the patch.

> packet-dcerpc-nt.c: Added dcerpc prefix to all names where missing.

great

> packet-dhcpv6.c: Added missing display filter name for "reserved" field.

great

> packet-dtp.c: Added dtp prefix and corrected tlv typo.

Hrm; I reckon it's a dtp typo. I've changed it to dtp.neighbor.

> packet-dvmrp.c: Replaced likely copy-and-paste "igmp." field names prefixes
> with "dvmrp."

great.

AIUI, the source files for packet-dcerpc-dssetup.c are part of the samba
source, so changing them locally doesn't make much sense. Afaics, it needs a
dssetup.cnf to remap the field names... might want to check all this with
Ronnie or one of the others on wireshark-dev, however.

Anyway, I'm marking this bug closed.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.