http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1811
------- Comment #4 from martin.r.mathieson@xxxxxxxxxxxxxx 2007-08-31 10:12 GMT -------
I've done some testing (and successful fuzz-testing), and I think it could be
checked in now. Unfortunately I won't have time to do this myself until Monday
at the earliest.
Here are a few quick comments:
(1) some of the tlv definitions don't match in all cases what I see in my
example captures (I'm sure these can be resolved as the spec settles down -
I'll ask someone who has been involved with such things to look at this next
week)
(2) I'd probably add more expert items to report more things like:
- length fields not being consistent with that implied by type of TLV
- unknown tlv codes
(3) I notice that the field of the tlv parent is wimaxasncp.tlv_type. I'd
rather it were just a byte-string field, e.g. wimaxasncp.tlv, then maybe have
the child nodes be e,g, wimaxasncp.tlv.length, etc. This is probably just a
matter of taste. There are some other little prettifications that I'd want to
make.
(4) For my own local testing, I added the line
new_register_dissector("wimaxasncp", dissect_wimaxasncp, proto_wimaxasncp);
to proto_register_wimaxasncp(), so that it can be found, if necessary, by the
dct2000 dissector
(5) Its not possible to set a filter to do a comparison with the value of a
certain tlv, e.g. you can't do 'wimaxasncp.avp.ms_nai == "base_station_w3"
(6) I notice some template comments (from README.developer?) at the end of the
file. It may be worth adding a port preference, although I haven't seen
examples that used a different port.
Points (1), (3) and (5) remind me strongly of Diameter dissector issues, and I
wonder if this dissector should (eventually) be done in a similar way, i.e.
- read the tlv definitions in from one or more XML files at run-time
- dynamically register filters such as described in (5)
I've no idea if I'd be allowed to share the capture I used for fuzz-testing.
One of the messages is reported as malformed, so I'd at least like to get to
the bottom of that first.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.